chore(RHINENG-9387): update page titles #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commits missing Jira IDs: |
bastilian
reviewed
Apr 29, 2024
| - ${intl.formatMessage(messages.systemsHeader)} - ${intl.formatMessage(messages.pageTitleSuffix)}`); | ||
| chrome.updateDocumentTitle( | ||
| `${entity.display_name} - Systems - Vulnerability | RHEL`, | ||
| true |
There was a problem hiding this comment.
Instead of adding the suffix manually here and disabling chrome adding a suffix, we can change the suffix for all apps in chrome itself: https://github.com/RedHatInsights/insights-chrome/blob/03a0a14126a88ece38d34ad24b43692f67a5e662/src/hooks/useBundle.ts#L22
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2101 +/- ##
==========================================
- Coverage 67.58% 66.63% -0.96%
==========================================
Files 131 127 -4
Lines 3437 3432 -5
Branches 1066 1066
==========================================
- Hits 2323 2287 -36
- Misses 1114 1145 +31 ☔ View full report in Codecov by Sentry. |
gkarat
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/RHINENG-9387
Updates page titles according to 'Current concept' column, single line treatment in this sheet