Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-9580 Fix tag modal crashing #2100

Merged
merged 1 commit into from Apr 25, 2024

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Apr 24, 2024

@leSamo leSamo requested a review from a team as a code owner April 24, 2024 20:49
Copy link

jira-linking bot commented Apr 24, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-9580

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.62%. Comparing base (df3416c) to head (410ea0a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
- Coverage   67.58%   66.62%   -0.97%     
==========================================
  Files         131      127       -4     
  Lines        3437     3431       -6     
  Branches     1066     1066              
==========================================
- Hits         2323     2286      -37     
- Misses       1114     1145      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LiorKGOW LiorKGOW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leSamo Thank you for the PR !
I have checked in my local environment and this solves the bug 🥳
Very elegant solution 💪🏼

@leSamo leSamo merged commit 86da24e into RedHatInsights:master Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants