Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RHINENG-7043): adopt fec-fonfig #2093

Merged
merged 8 commits into from Apr 10, 2024

Conversation

mkholjuraev
Copy link
Contributor

@mkholjuraev mkholjuraev requested a review from a team as a code owner April 5, 2024 10:50
Copy link

jira-linking bot commented Apr 5, 2024

Commits missing Jira IDs:
9161745
7336d1b
58e53c7
9d961da
Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-7043

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.62%. Comparing base (f8e9d4d) to head (9d961da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
- Coverage   67.58%   66.62%   -0.97%     
==========================================
  Files         131      127       -4     
  Lines        3437     3431       -6     
  Branches     1066     1066              
==========================================
- Hits         2323     2286      -37     
- Misses       1114     1145      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if Hot module reload was working, this might be blocking it
Tried to play with the package.json a bit but couldn't figure it out
image

@mkholjuraev
Copy link
Contributor Author

@AsToNlele this should be ready for a review now.

@mkholjuraev
Copy link
Contributor Author

Tests are passing locally, but failing here. Investigating why ...

@mkholjuraev
Copy link
Contributor Author

Cy tests automagically passing after Travis cache for this specific PR is deleted. Should be cy hiccup.

'react-router-dom': {
singleton: true,
import: false,
version: '^6.8.1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastilian I have pushed the necessary changes. PTAL

Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @mkholjuraev!

@mkholjuraev mkholjuraev merged commit 73fd746 into RedHatInsights:master Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants