New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(RHINENG-7043): adopt fec-fonfig #2093
chore(RHINENG-7043): adopt fec-fonfig #2093
Conversation
Commits missing Jira IDs: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2093 +/- ##
==========================================
- Coverage 67.58% 66.62% -0.97%
==========================================
Files 131 127 -4
Lines 3437 3431 -6
Branches 1066 1066
==========================================
- Hits 2323 2286 -37
- Misses 1114 1145 +31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AsToNlele this should be ready for a review now. |
Tests are passing locally, but failing here. Investigating why ... |
Cy tests automagically passing after Travis cache for this specific PR is deleted. Should be cy hiccup. |
'react-router-dom': { | ||
singleton: true, | ||
import: false, | ||
version: '^6.8.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as in the Patch PR: RedHatInsights/patchman-ui#1178 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bastilian I have pushed the necessary changes. PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @mkholjuraev!
Resolves: https://issues.redhat.com/browse/RHINENG-7043