fix: double icons in display name column on package systems table #1183
Conversation
| @@ -95,14 +95,6 @@ export const advisorySystemsColumns = () => [ | |||
| ]; | |||
|
|
|||
| export const packageSystemsColumns = [ | |||
| { | |||
| key: 'display_name', | |||
There was a problem hiding this comment.
I think we still have to have 'display_name' as a string in the columns definition. That way the Inventory knows where we want to show the display_name column, but we won't override the default column.
... I believe { key: 'display_name' } might work too.
There was a problem hiding this comment.
I believe we are safe to remove this column definition. Because, the inventory module merges those columns by default to those patch related columns that we pass in.
There was a problem hiding this comment.
I have removed tags column definition as well as it is also not necessary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
- Coverage 63.84% 63.83% -0.02%
==========================================
Files 124 124
Lines 3225 3224 -1
Branches 826 826
==========================================
- Hits 2059 2058 -1
Misses 1166 1166 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.67.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Associated Jira ticket: No ticket needed
A small fix for the double icons on the package systems page. As the page completely uses the inventory table and also there were extra column definition, double icons appeared. Removing the extra one fixes it.
I am not sure even if this icon should be displayed in package systems table. I will consult it with the ux.
How to test the PR
Please include steps to test your PR.
Before the change
After the change
Dependent work link
Checklist: