Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): audit fix modules #1176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fewwy
Copy link
Contributor

@Fewwy Fewwy commented Mar 14, 2024

Small update of packages running npm audit fix

@Fewwy Fewwy added the dependencies Pull requests that update a dependency file label Mar 14, 2024
@Fewwy Fewwy self-assigned this Mar 14, 2024
@Fewwy Fewwy requested a review from a team as a code owner March 14, 2024 16:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.15%. Comparing base (d834881) to head (3f6fe16).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1176   +/-   ##
=======================================
  Coverage   63.15%   63.15%           
=======================================
  Files         127      127           
  Lines        3224     3224           
  Branches      826      826           
=======================================
  Hits         2036     2036           
  Misses       1188     1188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"version": "4.2.4",
"resolved": "https://registry.npmjs.org/@redhat-cloud-services/frontend-components/-/frontend-components-4.2.4.tgz",
"integrity": "sha512-5xne/DD1/+txtN50YOrKPeJKpSgENkGz4o4oqYMRB+ElJwnupsaOasvyfMwImKggDcAZ/uWLXt8KNoE8ZXhVvA==",
"version": "4.2.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to save the bumped versions of direct dependencies in package.json as well, because that is the place where to look first, and someone might easily just drop the lock file and end up with older version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants