chore(deps): Update axios to fix CVE #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1167 +/- ##
=======================================
Coverage 62.84% 62.84%
=======================================
Files 127 127
Lines 3192 3192
Branches 817 817
=======================================
Hits 2006 2006
Misses 1186 1186 ☔ View full report in Codecov by Sentry. |
mkholjuraev
approved these changes
Mar 1, 2024
| const { response, isAxiosError } = { ...err }; | ||
|
|
||
| if (response && isAxiosError) { | ||
| if (response && err.isAxiosError) { |
There was a problem hiding this comment.
For my understanding, what was the issue here?
There was a problem hiding this comment.
In the new version of axios
const { response, isAxiosError } = { ...err }
console.log(isAxiosError); // prints "undefined"
console.log(err.isAxiosError); // prints "true"It seems like by copying the object the destructuring and direct property access behave differently.
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
🎉 This PR is included in version 1.67.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/RHINENG-8635
Axios did have an error handler refactoring in 0.27.0, therefore I had to change the accessor to
isAxiosError.