Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OperatingSystemFilter): RHINENG-10345 - Fix OS inventory filter conversion #1152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastilian
Copy link
Member

This fixes issues with syncing the state and URL of filters in the Systems table.

Description

Associated Jira ticket: # (issue)

Please include a summary of the change, what this fixes/creates/improves.

How to test the PR

Please include steps to test your PR.

Before the change

After the change

Dependent work link

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 64.09%. Comparing base (7f7bc89) to head (bc453aa).

Files Patch % Lines
src/SmartComponents/Systems/SystemsTable.js 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
- Coverage   64.14%   64.09%   -0.06%     
==========================================
  Files         124      124              
  Lines        3207     3222      +15     
  Branches      818      825       +7     
==========================================
+ Hits         2057     2065       +8     
- Misses       1150     1157       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bastilian bastilian changed the title fix(OperatingSystemFilter): RHINENG-2912 - Fix OS inventory filter conversion fix(OperatingSystemFilter): RHINENG-10345 - Fix OS inventory filter conversion May 29, 2024
@bastilian bastilian marked this pull request as ready for review May 29, 2024 10:48
@bastilian bastilian requested a review from a team as a code owner May 29, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants