fix(Remediating): SPM-2000 - Selecting all systems selected filtered …

[AsToNlele]

Description

Associated Jira ticket: SPM-2000

Selecting all systems while having filters remediates now correct amount of systems

How to test the PR

1. Go to Patch Systems
2. Apply some filters
3. Select all
4. You can remediate only systems that have installable advisories, so ideally count how many systems have Installable advisories
5. Remediate
6. Make sure the number of systems matches

Before the change

When selecting all systems while having filters, wrong system count is remediated

After the change

Correct amount is remediated

Dependent work link

Checklist:

• The commit message has the Jira ticket linked
• PR has a short description
• Screenshots before and after the change are added
• Tests for the changes have been added
• README.md is updated if necessary
• Needs additional dependent work

[codecov-commenter]

Codecov Report

Patch coverage: 25.00% and project coverage change: +0.07% 🎉

Comparison is base (4fb84ef) 63.15% compared to head (c5ed917) 63.23%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   63.15%   63.23%   +0.07%     
==========================================
  Files         120      120              
  Lines        2994     2984      -10     
  Branches      765      761       -4     
==========================================
- Hits         1891     1887       -4     
+ Misses       1103     1097       -6     

Files Changed	Coverage Δ
src/SmartComponents/Advisories/Advisories.js	100.00% <ø> (ø)
src/Utilities/RemediationPairs.js	0.00% <0.00%> (ø)
src/store/Reducers/AdvisoryListStore.js	80.00% <ø> (+10.43%)	⬆️
src/store/Reducers/SystemsStore.js	100.00% <ø> (+17.64%)	⬆️
src/SmartComponents/Systems/Systems.js	78.78% <100.00%> (-0.63%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leSamo]

For some reason every time I try to open Status filter and click on a checkbox the whole page freezes and the tab crashes later, and I quite can't put my finger on why it happens, can you add and remove Status filter without page hanging?

[AsToNlele]

/retest

[leSamo]

@AsToNlele were you able to reproduce/fix the issue I mentioned in my previous comment? I believe the last force push was just a rebase, or did it include any changes?

[AsToNlele]

I wasn't able to reproduce, yeah I just rebased 😄

[AsToNlele]

/retest

[mkholjuraev]

@AsToNlele seems the issue has been resolved.

[mkholjuraev]

Probably we can close this :)