Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Quarkus to 2.3.1.Final #718

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Bump Quarkus to 2.3.1.Final #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 1 addition & 13 deletions backend/src/main/java/com/redhat/cloud/notifications/routers/LivenessService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import com.redhat.cloud.notifications.StuffHolder;
import io.smallrye.health.api.AsyncHealthCheck;
import io.smallrye.mutiny.Uni;
import io.smallrye.mutiny.vertx.MutinyHelper;
import io.vertx.core.Vertx;
import org.eclipse.microprofile.health.HealthCheckResponse;
import org.eclipse.microprofile.health.HealthCheckResponseBuilder;
import org.eclipse.microprofile.health.Liveness;
Expand All @@ -20,9 +18,6 @@ public class LivenessService implements AsyncHealthCheck {
@Inject
Mutiny.SessionFactory sessionFactory;

@Inject
Vertx vertx;

@Override
public Uni<HealthCheckResponse> call() {
boolean adminDown = StuffHolder.getInstance().isAdminDown();
Expand All @@ -44,13 +39,6 @@ private Uni<Boolean> postgresConnectionHealth() {
.getSingleResult()
.replaceWith(Boolean.TRUE)
.onFailure().recoverWithItem(Boolean.FALSE);
}).runSubscriptionOn(
/*
* AsyncHealthCheck does not work with Hibernate Reactive. The following line is a workaround for that issue.
* TODO Remove it ASAP.
* See https://github.com/quarkusio/quarkus/issues/20166 for more details.
*/
MutinyHelper.executor(vertx.getOrCreateContext())
);
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quarkusio/quarkus#20166 was fixed in Quarkus 2.3.1.Final.

}
}
2 changes: 1 addition & 1 deletion backend/src/test/java/com/redhat/cloud/notifications/processors/webhook/WebhookTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
@QuarkusTestResource(TestLifecycleManager.class)
public class WebhookTest extends DbIsolatedTest {

private static final long MAX_RETRY_ATTEMPTS = 3L;
private static final long MAX_RETRY_ATTEMPTS = 4L;
Copy link
Member Author

@gwenneg gwenneg Oct 20, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smallrye/smallrye-mutiny#678 was fixed in Quarkus 2.3.1.Final.


@MockServerConfig
MockServerClientConfig mockServerConfig;
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@

<quarkus.platform.artifact-id>quarkus-universe-bom</quarkus.platform.artifact-id>
<quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
<quarkus.platform.version>2.3.0.Final</quarkus.platform.version>
<quarkus.platform.version>2.3.1.Final</quarkus.platform.version>
</properties>

<dependencyManagement>
Expand Down