Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump com.fasterxml.jackson.core:jackson-core from 2.16.1 to 2.17.0 #212

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 18, 2024

Bumps com.fasterxml.jackson.core:jackson-core from 2.16.1 to 2.17.0.

Commits
  • 8fba680 [maven-release-plugin] prepare release jackson-core-2.17.0
  • 486b33f Prepare for 2.17.0 release
  • a6a1074 Merge branch '2.16' into 2.17
  • e5b5e34 Back to snapshot deps
  • 8938de4 [maven-release-plugin] prepare for next development iteration
  • 4162dfc [maven-release-plugin] prepare release jackson-core-2.16.2
  • 37ef9b3 Prepare for 2.16.2 release
  • e2cc65d Bump the github-actions group with 3 updates (#1236)
  • d29507f Improve #1149 wrt JsonParser.getNumberTypeFP() default implementation (#1235)
  • 1994217 Add explicit override for JSON parsers for JsonParser.getNumberTypeFP()
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.16.1 to 2.17.0.
- [Commits](FasterXML/jackson-core@jackson-core-2.16.1...jackson-core-2.17.0)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 18, 2024
@franz1981
Copy link
Contributor

FYI FasterXML/jackson-core#1250 (comment)

Bumping to newer version will make the pattern to thrown away object mappers, pretty dangerous performance wise (unless the object mappers is configured to use a ThreadLocal shared pool, likely - or reuse the same lock free shared pool, saved in some soft-ref singleton-like)

@franz1981
Copy link
Contributor

@kittylyst @jponge @ehsavoie

@cowtowncoder
Copy link

One quick note: throwing away ObjectMappers has always been colossally bad idea, performance-wise. Not much has changed with 2.17: overhead of first call via mappers dwarfs any read/write activity in most use cases. So the best optimization tip one can give is to reuse mappers.
In the least bad case of using, say, ObjectMapper.readTree() (where no POJO introspection is needed), performance is 50% lower for small content. Same for serialization side.

In 2.17 there is additional potential hit due to change from ThreadLocal-based buffer pool to per-JsonFactory (and thereby per ObjectMapper), but that should usually be only modest additional injury to the main problem.

So, if there are use patterns where mappers are constructed on per-call basis, it would probably make sense to try to figure out if reuse it at all possible.

@franz1981
Copy link
Contributor

Thanks for the details @cowtowncoder much appreciated!

@kittylyst
Copy link
Collaborator

Note that in this case, we send data once every 24 hours. Performance is not really a concern.

@cowtowncoder
Copy link

Ok that is good to know @kittylyst.

It sounds like upgrade should not change this situation, i.e. reuse or not is a pre-existing condition and tolerable since performance (of this aspect) doesn't matter a lot overall.

Copy link
Contributor Author

dependabot bot commented on behalf of github May 6, 2024

Superseded by #217.

@dependabot dependabot bot closed this May 6, 2024
@dependabot dependabot bot deleted the dependabot/maven/com.fasterxml.jackson.core-jackson-core-2.17.0 branch May 6, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants