fix: remove node export map entries #7419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These entries cause node to resolve to commonjs in all cases, rather than respecting the consumer's module `type`. For example, a consumer with `"type": "module"` will still resolve to the commonjs entrypoint since node will choose the `node` entry before the `default` entry.
|
this has now uncovered that the published ESM doesn't work in node anyhow, since rxjs' it means we resolve to the esm entrypoint successfully now (and didn't before), but the resolved file is treated as commonjs. we would have to rename all the esm output to |
|
abandoning this since it sounds like there's a plan to do it as part of a larger change further ahead in future will just have to manage for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These entries cause node to resolve to commonjs in all cases, rather than respecting the consumer's module
type.For example, a consumer with
"type": "module"will still resolve to the commonjs entrypoint since node will choose thenodeentry before thedefaultentry.