docs: use a processor to transform the operator decision tree data #7388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tmair ! I really appreciate all of this good work. Generally, I'm not the one that reviews anything to do with the docs app, so I've been deferring to @jakovljevic-mladen and @niklas-wortmann for that. This seems like a nice add though. |
jakovljevic-mladen
requested review from
niklas-wortmann and
jakovljevic-mladen
niklas-wortmann
approved these changes
Dec 29, 2023
jakovljevic-mladen
requested changes
Jan 3, 2024
There was a problem hiding this comment.
@tmair, this PR is awesome, thank you a lot for merging Operator Decision Tree generator to the tools that already exist.
I have one comment regarding a file rename; everything else looks great. Also, conflicts need to be resolved.
tmair
force-pushed
the
decision-tree-generator-as-processor
branch
from
0543d3e
to
ce11b2e
Compare
I rebased the PR and addressed the comment about the renaming of the file. |
jakovljevic-mladen
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR moves the generation of the decision tree into a dgeni processor, so that the decision tree will be generated as part of the documentation generation.
Related issue (if exists):
None