Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix missing overloads in docs when overload count is less than 3 #7367

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

tmair
Copy link
Contributor

@tmair tmair commented Oct 29, 2023

Description:
This PR fixes an issue in the docs app, that does not display the overlays if the number of overloads is 2. The overload is printed at the top of the document.

Related issue (if exists): #5281

See also AIO Commit: angular/angular@e0c7360

@benlesh
Copy link
Member

benlesh commented Oct 29, 2023

This may require a separate PR for 7.x (The current website) cc @jakovljevic-mladen

@benlesh benlesh merged commit d787879 into ReactiveX:master Oct 29, 2023
3 checks passed
@benlesh
Copy link
Member

benlesh commented Oct 29, 2023

Thank you, @tmair

@tmair tmair deleted the fix-overload-docs branch October 29, 2023 20:08
@jakovljevic-mladen
Copy link
Member

This may require a separate PR for 7.x

I agree.

@tmair, if you'd like, please create a PR against 7.x branch. Otherwise, I could create it later this week. Thanks for the fix @tmair.

@tmair
Copy link
Contributor Author

tmair commented Oct 30, 2023

@tmair, if you'd like, please create a PR against 7.x branch. Otherwise, I could create it later this week.

Here is the PR for the 7.x branch: #7369

@jakovljevic-mladen I think that also the associated issue can be closed after the fix has landed on the 7.x branch.

@jakovljevic-mladen
Copy link
Member

Thanks @tmair.

If you want to automatically close related issue, you can just write somewhere in the PR description Closes #7369. Please check this guide for more info. However, since it only works when merging against main branch, I will close it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants