Async dispatched config handlers #7344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys async dispatch Resolves ReactiveX#7343
benlesh
force-pushed
the
async-dispatched-config-handlers
branch
from
29982fd
to
4a30be8
Compare
benlesh
commented
Sep 21, 2023
| const sharedSource = source.pipe(share({ resetOnComplete: () => reset, resetOnRefCountZero })); | ||
|
|
||
| const result = concat(sharedSource, firstPause, sharedSource); | ||
| it('should not call "resetOnRefCountZero" on error', () => { |
There was a problem hiding this comment.
Everything under this section is really a whitespace change. I'm not sure why the diff is flipping out here. This was just from reorganizing things in the file I think.
benlesh
commented
Sep 21, 2023
| @@ -810,9 +797,22 @@ describe('share', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should not reset on refCount 0 if reset notifier errors before emitting any value', () => { | |||
| spyOnUnhandledError((onUnhandledError) => { | |||
| describe('when config.onUnhandledError is set', () => { | |||
There was a problem hiding this comment.
Adding this describe block is what I think messed with the whitespace diff in other parts of the file.
benlesh
commented
Sep 21, 2023
| @@ -856,89 +855,86 @@ describe('share', () => { | |||
| expectObservable(result, subscription).toBe(expected); | |||
| expectSubscriptions(source.subscriptions).toBe(sourceSubs); | |||
| }); | |||
|
|
|||
| expect(onUnhandledError).to.have.been.calledOnce; | |||
There was a problem hiding this comment.
These tests were errant, in that they were able to check to see if onUnhandledError was dispatched synchronously, which it was never supposed to be.
benlesh
commented
Sep 22, 2023
| @@ -267,7 +266,7 @@ function createSafeObserver<T>(observerOrNext?: Partial<Observer<T>> | ((value: | |||
| */ | |||
| function handleStoppedNotification(notification: ObservableNotification<any>, subscriber: Subscriber<any>) { | |||
| const { onStoppedNotification } = config; | |||
| onStoppedNotification && timeoutProvider.setTimeout(() => onStoppedNotification(notification, subscriber)); | |||
| onStoppedNotification && setTimeout(() => onStoppedNotification(notification, subscriber)); | |||
There was a problem hiding this comment.
One important bit is here.
benlesh
commented
Sep 22, 2023
| @@ -11,7 +10,7 @@ import { timeoutProvider } from '../scheduler/timeoutProvider'; | |||
| * @param err the error to report | |||
| */ | |||
| export function reportUnhandledError(err: any) { | |||
| timeoutProvider.setTimeout(() => { | |||
| setTimeout(() => { | |||
There was a problem hiding this comment.
The other important bit is here.
jakovljevic-mladen
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removing dependency on
timeoutProviderinObservablebecause observable depends onSubscriber, andSubscriberuserstimeoutProviderfor bothonUnhandledErrorandonStoppedNotification, when it doesn't really need to. That's not particularly whattimeoutProvideris for.This also preps us to publish
@rxjs/observableby limiting the dependencies thatObservablehas.Resolves #7343