Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fromEvent): allow fromEvent to handle symbols as event names #7339

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

demensky
Copy link
Contributor

Allow passing a value of type symbol to eventName if a NodeStyleEventEmitter is passed to source, according to the documentation.

Closes #7338

Allow passing a value of type `symbol` to `eventName` if
a `NodeStyleEventEmitter` is passed to `source`, according to
[the documentation](https://nodejs.org/api/events.html#emitteraddlistenereventname-listener).

Closes ReactiveX#7338
@demensky demensky marked this pull request as ready for review October 29, 2023 22:02
@benlesh benlesh merged commit 224e975 into ReactiveX:master Dec 19, 2023
3 checks passed
@benlesh
Copy link
Member

benlesh commented Dec 19, 2023

Thank you, @demensky !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Support for Symbol for fromEvent
2 participants