fix(buffer): subscribe to the closing notifier before the source #7185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct at a glance. We'll just need to resolve the merge conflicts. |
|
Merge conflicts are prevailing these days 😃 |
jakovljevic-mladen
force-pushed
the
fix_buffer_subscriptions
branch
from
1953d9a
to
ab9e170
Compare
benlesh
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Per RxJS Core Semantics guide:
This PR fixes this issue in
bufferoperator. Since there was a test related to this, I adjusted it so that it works with the new setup.Also, one note: since we waited with similar bug for v8 in #7152, I think this should not be cherry picked to v7 branch.
Related issue (if exists):
None, only this comment.