Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove broken types reference in package.json #6790

Closed
wants to merge 1 commit into from

Conversation

corinnaerin
Copy link

@corinnaerin corinnaerin commented Feb 2, 2022

Description:

The types field in package.json references a type definition file that does not exist. This causes eslint-plugin-import to fail when it tries to resolve the reference:

image

example.ts looks like this:

import { BehaviorSubject } from "rxjs";

const a = new BehaviorSubject(1);
console.log(a.getValue());

TypeScript successfully resolves the package, but eslint-plugin-import does not (I'm using the latest version of this package). Removing the broken types reference fixes the issue.

@corinnaerin corinnaerin changed the title git: remove broken types reference in package.json fix: remove broken types reference in package.json Feb 2, 2022
@kwonoj
Copy link
Member

kwonoj commented Feb 2, 2022

This is dupe of #6466 (comment)

and its comments to upstream comment microsoft/TypeScript#43034 (comment) that we are intentionally following TypeScript core team's suggestion for supporting type resolutions with supported typescript version.

@corinnaerin
Copy link
Author

Oh ok sorry! I did a search of past issues, I guess I didn't search thoroughly enough.

I will open a bug report with eslint-plugin-import instead for them to support this use case.

@corinnaerin corinnaerin closed this Feb 2, 2022
@corinnaerin corinnaerin deleted the fix-types-ref branch February 2, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants