Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ajax): crossDomain flag deprecated and properly reported to consumers #6710

Merged
merged 3 commits into from Jan 11, 2022
Merged

fix(ajax): crossDomain flag deprecated and properly reported to consumers #6710

merged 3 commits into from Jan 11, 2022

Commits on Jan 4, 2022

  1. fix(ajax): crossDomain flag deprecated and properly reported to consu… 

    …mers

Fixes an issue where the `crosDomain` flag was being incorrectly reported to users via error objects and response objects as defaulting to `true`, when it was in fact defaulting to `false`.

Deprecates the `crossDomain` flag in favor of allowing the configuration of the request and the browser to dictate whether or not a preflight request is necessary. Adds deprecation messages with advice about how to force CORS preflights. Ultimately, the boolean flag does not make sense, as there are a lot of factors that dictate CORS preflight use and they may vary by browser/environment.

Resolves ReactiveX#6663
    @benlesh
    benlesh committed Jan 4, 2022
    Copy the full SHA
    2d19ba8 View commit details
    Browse the repository at this point in the history

  2. chore: Update side effects file

    @benlesh
    benlesh committed Jan 4, 2022
    Copy the full SHA
    a7c4de0 View commit details
    Browse the repository at this point in the history

  3. chore: update side effects files

    @benlesh
    benlesh committed Jan 4, 2022
    Copy the full SHA
    cb1823a View commit details
    Browse the repository at this point in the history