Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forkJoin/combineLatest return Observable<unknown> if passed any #6227

Merged
merged 4 commits into from Apr 15, 2021
Merged

fix: forkJoin/combineLatest return Observable<unknown> if passed any #6227

merged 4 commits into from Apr 15, 2021

Commits on Apr 14, 2021

  1. fix: forkJoin/combineLatest return Observable<unknown> if passed any 

    Resolves ReactiveX#6226
    @benlesh
    benlesh committed Apr 14, 2021
    Copy the full SHA
    43da0a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. chore: make shenanigans readonly 

    Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
    @benlesh @DanielRosenwasser
    benlesh and DanielRosenwasser committed Apr 15, 2021
    Copy the full SHA
    f8d7fc5 View commit details
    Browse the repository at this point in the history

  2. chore: Ensure there is no way the arg should work 

    If the user passed that exact shape of object in AnyCatcher, technically it should work. This ensures there's no way it would work properly so `Observable<unknown>` is accurate.

Also adds some documentation to the areas
    @benlesh
    benlesh committed Apr 15, 2021
    Copy the full SHA
    951e74a View commit details
    Browse the repository at this point in the history

  3. refactor: Move any catcher signatures up

    @benlesh
    benlesh committed Apr 15, 2021
    Copy the full SHA
    c6ff1c9 View commit details
    Browse the repository at this point in the history