refactor: removed useless thisArg from createFind

ReactiveX · Jan 20, 2023 · b69785b · b69785b
1 parent cd54089
commit b69785b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/internal/operators/find.ts b/src/internal/operators/find.ts
@@ -51,14 +51,10 @@ export function find<T>(predicate: (value: T, index: number, source: Observable<
  * matches the condition.
  */
 export function find<T>(predicate: (value: T, index: number, source: Observable<T>) => boolean): OperatorFunction<T, T | undefined> {
-  return operate(createFind(predicate, undefined, 'value'));
+  return operate(createFind(predicate, 'value'));
 }
 
-export function createFind<T>(
-  predicate: (value: T, index: number, source: Observable<T>) => boolean,
-  thisArg: any,
-  emit: 'value' | 'index'
-) {
+export function createFind<T>(predicate: (value: T, index: number, source: Observable<T>) => boolean, emit: 'value' | 'index') {
   const findIndex = emit === 'index';
   return (source: Observable<T>, subscriber: Subscriber<any>) => {
     let index = 0;
@@ -67,7 +63,7 @@ export function createFind<T>(
         subscriber,
         (value) => {
           const i = index++;
-          if (predicate.call(thisArg, value, i, source)) {
+          if (predicate(value, i, source)) {
             subscriber.next(findIndex ? i : value);
             subscriber.complete();
           }

diff --git a/src/internal/operators/findIndex.ts b/src/internal/operators/findIndex.ts
@@ -48,5 +48,5 @@ export function findIndex<T>(predicate: (value: T, index: number, source: Observ
  * first item that matches the condition.
  */
 export function findIndex<T>(predicate: (value: T, index: number, source: Observable<T>) => boolean): OperatorFunction<T, number> {
-  return operate(createFind(predicate, undefined, 'index'));
+  return operate(createFind(predicate, 'index'));
 }