Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeliverable error handling logic for Completable operators #6442

Merged
merged 3 commits into from Mar 26, 2019

Conversation

BharathMG
Copy link

@BharathMG BharathMG commented Mar 25, 2019

Completable.fromAction and Completable.fromRunnable operators were missing RxJavaPlugins calls to handle Undeliverable errors. This behaviour is fixed in this PR.

Also added missing error handling java doc for Completable.fromRunnable.

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #6442 into 2.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6442      +/-   ##
============================================
+ Coverage     98.27%   98.29%   +0.02%     
+ Complexity     6297     6295       -2     
============================================
  Files           675      675              
  Lines         45171    45173       +2     
  Branches       6246     6246              
============================================
+ Hits          44391    44402      +11     
  Misses          238      238              
+ Partials        542      533       -9
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 120 <0> (ø) ⬇️
...l/operators/completable/CompletableFromAction.java 100% <100%> (ø) 4 <0> (ø) ⬇️
...operators/completable/CompletableFromRunnable.java 100% <100%> (ø) 4 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...tivex/internal/operators/single/SingleTimeout.java 98.33% <0%> (-1.67%) 2% <0%> (ø)
...activex/internal/schedulers/ExecutorScheduler.java 95.97% <0%> (-1.01%) 10% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.06% <0%> (-0.94%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 96.58% <0%> (-0.86%) 2% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cb174...4db86d1. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 backlog milestone Mar 25, 2019
@akarnokd akarnokd merged commit 0b3558d into ReactiveX:2.x Mar 26, 2019
@BharathMG BharathMG deleted the error-handle-patch branch March 27, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants