Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a race condition in OperatorMerge.InnerSubscriber#onError #5851

Merged
merged 2 commits into from Feb 15, 2018
Merged

Fix a race condition in OperatorMerge.InnerSubscriber#onError #5851

merged 2 commits into from Feb 15, 2018

Commits on Feb 14, 2018

  1. Fix a race condition in OperatorMerge.InnerSubscriber#onError 

    Inner subscriber must queue the error first before setting done,
so that after emitLoop() removes the subscriber,
emitLoop is guaranteed to notice the error.
Otherwise it would be possible that inner subscribers count was 0,
and at the same time the error queue was empty.
    @pkolaczk
    pkolaczk committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    61e3607 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Add unit test for OperatorMerge.InnerSubscriber#onError race

    @pkolaczk
    pkolaczk committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    9b8460d View commit details
    Browse the repository at this point in the history