Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs/asynciterable/converting.md): Fix fromEventPattern import #350

Merged

Conversation

michaelsbradleyjr
Copy link
Contributor

@michaelsbradleyjr michaelsbradleyjr commented Nov 11, 2022

NOTE: There's a subtle problem that I did not attempt to address in this PR related to module resolution. I've been away from the JS/Node ecosystem for a couple of years (though I'm a longtime fan of Ix!) and in order to run .js code (via Node in a terminal) copied from the docs pertaining to this PR, I found I needed to change e.g.

import { fromEventPattern } from 'ix/asynciterable';

to

import { fromEventPattern } from 'ix/asynciterable/index.js';

And I needed to add "type": "module" to package.json relative to the scripts I've been using for experimentation.

Alternatively, after adding "type": "module" to package.json, I could run my scripts by supplying the --experimental-specifier-resolution=node option in my terminal, i.e. without changing the import statement copied from Ix's docs.

Anyway, just a heads up.

@michaelsbradleyjr
Copy link
Contributor Author

michaelsbradleyjr commented Nov 11, 2022

I just realized my notes in the PR description are related to #342, but this PR itself is unrelated, i.e. this PR is only about fixing an import statement in the docs.

@trxcllnt trxcllnt merged commit f07b7ef into ReactiveX:master Nov 14, 2022
@michaelsbradleyjr michaelsbradleyjr deleted the docs/asynciterable_converting branch November 14, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants