Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix memory leak on application reference destroy #1

Merged
merged 1 commit into from Apr 4, 2018
Merged

fix(core): fix memory leak on application reference destroy #1

merged 1 commit into from Apr 4, 2018

Conversation

RatkoR
Copy link
Owner

@RatkoR RatkoR commented Apr 4, 2018

When an application reference is destroyed it stays in memory because it is still registered in the testability registry.

Closes angular#22106, angular#13725

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

When an application reference is destroyed it stays in memory because it is still registered in the testability registry.

Closes angular#22106, angular#13725
@RatkoR RatkoR merged commit 3c46dc7 into RatkoR:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants