Switch to mypy part0

.github/workflows/continous-integration.yml

@@ -102,6 +102,9 @@ jobs:
     - name: Check Types 📚
       run: make types
 
+    - name: Check Types (old) 📚
+      run: make types-old
+
     - name: Test CLI 🖥
       # makes sure we catch any dependency error early. they will create strange
       # errors during the docs build, so easier to catch them early on by

.gitignore

@@ -16,6 +16,7 @@ venv
 .ruby-version
 .tox
 .pytype
+.mypy_cache/
 dist/
 pip-wheel-metadata
 server/

CONTRIBUTING.md

@@ -85,15 +85,15 @@ If your PR is greater than 500 lines, please consider splitting it into multiple
 
 #### Code style
 
-To ensure a standardized code style we recommend using formatter black. To ensure our type annotations are correct we also suggest using the type checker pytype.
+To ensure a standardized code style we recommend using formatter black. To ensure our type annotations are correct we also suggest using the type checker `mypy`.
 
 #### Formatting and Type Checking
 
 If you want to automatically format your code on every commit, you can use pre-commit. Just install it via `pip install pre-commit` and execute `pre-commit install` in the root folder. This will add a hook to the repository, which reformats files on every commit.
 
 If you want to set it up manually, install black via `pip install -r requirements-dev.txt.` To reformat files execute `make formatter`.
 
-If you want to check types on the codebase, install pytype using `pip install -r requirements-dev.txt`. To check the types execute `make types`.
+If you want to check types on the codebase, install `mypy` using `pip install -r requirements-dev.txt`. To check the types execute `make types`.
 
 The CI/CD tests that we run can be found in the [continous-integration.yml](https://github.com/RasaHQ/rasa/blob/master/.github/workflows/continous-integration.yml) file. 
 

Makefile

@@ -15,7 +15,7 @@ help:
 	@echo "    lint"
 	@echo "        Lint code with flake8, and check if black formatter should be applied."
 	@echo "    types"
-	@echo "        Check for type errors using pytype."
+	@echo "        Check for type errors using mypy."
 	@echo "    prepare-tests-ubuntu"
 	@echo "        Install system requirements for running tests on Ubuntu and Debian based systems."
 	@echo "    prepare-tests-macos"
@@ -37,7 +37,7 @@ clean:
 	find . -name '*.pyo' -exec rm -f {} +
 	find . -name '*~' -exec rm -f  {} +
 	rm -rf build/
-	rm -rf .pytype/
+	rm -rf .mypy_cache/
 	rm -rf dist/
 	rm -rf docs/build
 	rm -rf docs/.docusaurus
@@ -63,6 +63,30 @@ lint:
 	poetry run black --check rasa tests
 
 types:
+	# FIXME: working our way towards removing these
+	# see https://github.com/RasaHQ/rasa/pull/6470
+	# the list below is sorted by the number of errors for each error code, in decreasing order
+	poetry run mypy rasa --disable-error-code arg-type \
+	--disable-error-code assignment \
+	--disable-error-code var-annotated \
+	--disable-error-code return-value \
+	--disable-error-code union-attr \
+	--disable-error-code override \
+	--disable-error-code operator \
+	--disable-error-code attr-defined \
+	--disable-error-code index \
+	--disable-error-code misc \
+	--disable-error-code return \
+	--disable-error-code call-arg \
+	--disable-error-code type-var \
+	--disable-error-code list-item \
+	--disable-error-code has-type \
+	--disable-error-code valid-type \
+	--disable-error-code dict-item \
+	--disable-error-code no-redef \
+	--disable-error-code func-returns-value
+
+types-old:
 	poetry run pytype --keep-going rasa -j 16
 
 prepare-tests-files:

README.md

@@ -251,7 +251,7 @@ make formatter
 
 #### Type Checking
 
-If you want to check types on the codebase, install `pytype` using `poetry install`.
+If you want to check types on the codebase, install `mypy` using `poetry install`.
 To check the types execute
 ```
 make types

pyproject.toml

@@ -143,7 +143,6 @@ fakeredis = "^1.4.0"
 mongomock = "^3.18.0"
 black = "^19.10b0"
 flake8 = "^3.8.3"
-pytype = "^2020.6.1"
 google-cloud-storage = "^1.29.0"
 azure-storage-blob = "<12.6.0"
 coveralls = "^2.0.0"
@@ -152,6 +151,8 @@ toml = "^0.10.0"
 pep440-version-utils = "^0.3.0"
 pydoc-markdown = "^3.5.0"
 pytest-timeout = "^1.4.2"
+pytype = "^2020.6.1"
+mypy = "^0.790"
 
 [tool.poetry.extras]
 spacy = [ "spacy",]

rasa/core/policies/ted_policy.py

@@ -541,7 +541,8 @@ def __init__(
         self.action_acc = tf.keras.metrics.Mean(name="acc")
         self.metrics_to_log += ["loss", "acc"]
 
-        self.all_labels_embed = None  # needed for efficient prediction
+        # needed for efficient prediction
+        self.all_labels_embed: Optional[Tuple[tf.Tensor, tf.Tensor]] = None
 
         self._prepare_layers()
 

rasa/nlu/classifiers/diet_classifier.py

@@ -1115,7 +1115,9 @@ def __init__(
         self._create_metrics()
         self._update_metrics_to_log()
 
-        self.all_labels_embed = None  # needed for efficient prediction
+        # needed for efficient prediction
+        self.all_labels_embed: Optional[Tuple[tf.Tensor, tf.Tensor]] = None
+
         self._prepare_layers()
 
     @staticmethod

rasa/utils/tensorflow/models.py

@@ -666,7 +666,7 @@ def __init__(
         )
 
         # set up tf layers
-        self._tf_layers: Dict[Text : tf.keras.layers.Layer] = {}
+        self._tf_layers: Dict[Text, tf.keras.layers.Layer] = {}
 
     def _check_data(self) -> None:
         raise NotImplementedError

setup.cfg

@@ -19,3 +19,10 @@ log_cli_level = WARNING
 [flake8]
 max-line-length = 88
 ignore = W503, E121, E126, E211, E225, E501, E203, E402, F401, F811, E231
+
+[mypy]
+ignore_missing_imports = True
+show_error_codes = True
+warn_redundant_casts = True
+warn_unused_ignores = True
+# FIXME: more configuration using the --disable-error-code CLI argument (see types directive in Makefile)