plugin hmail-alias integration #2211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use com api instead of direct dp access
Test casesScenario: Logging in for the first time Scenario: Logging in for the second time Scenario: Logging in after changing the 'name; on the default identity Scenario: Logging in with an account which has multiple identities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request is not quite a duplicate of #1863
While @karobolas did admirable work on that pull request, there were a few issues. The major one being direct database access to hmail. This isn't recommended as the hmail COM api is a better choice. This Pull request uses that com api to get the user's first name and last name to use as the user identity in rainloop.
Also, instead of using direct filesystem IO to read/write to the json file that stores the user identity, I am now using the existing mechanisms in place to do such work.
I have tested this in my environment and confirmed it is working.