-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin unsplash-bg-updater #1867
Open
BloodyAltair
wants to merge
10
commits into
RainLoop:master
Choose a base branch
from
BloodyAltair:feature_unsplash-bg-updater_plugin
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
plugin unsplash-bg-updater #1867
BloodyAltair
wants to merge
10
commits into
RainLoop:master
from
BloodyAltair:feature_unsplash-bg-updater_plugin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BloodyAltair <me@bloody.pw>
+ no-inspection comments fix Signed-off-by: BloodyAltair <me@bloody.pw>
+ no-inspection comments fix Signed-off-by: BloodyAltair <me@bloody.pw>
…in' into feature_unsplash-bg-updater_plugin
…in' into feature_unsplash-bg-updater_plugin Signed-off-by: BloodyAltair <me@bloody.pw>
…in' into feature_unsplash-bg-updater_plugin
…in' into feature_unsplash-bg-updater_plugin Signed-off-by: BloodyAltair <me@bloody.pw>
…in' into feature_unsplash-bg-updater_plugin
Signed-off-by: BloodyAltair <me@bloody.pw>
Testing this now and it seems to be working great. My only suggestion is to allow a way for users to override the Unsplash theme if they would rather see something else than what is set through the Rainloop Admin panel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically updates page background with random image from Unsplash
Based on: https://github.com/BloodyAltair/UnsplashBackgroundUpdater