Skip to content

Commit

Permalink
Bump concurrent-ruby gem version
Browse files Browse the repository at this point in the history
It mitigates the issue causing segfaults on Ruby 2.5 and 2.6:

  - ruby-concurrency/concurrent-ruby#808

[#698]
  • Loading branch information
fidel committed Feb 14, 2020
1 parent 52758e2 commit 088d015
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ruby_event_store/ruby_event_store.gemspec
Expand Up @@ -25,5 +25,5 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.add_dependency 'concurrent-ruby', '~> 1.0'
spec.add_dependency 'concurrent-ruby', '~> 1.0', '>= 1.1.6'

This comment has been minimized.

Copy link
@mostlyobvious

mostlyobvious Feb 14, 2020

Member

Why two version specs?

This comment has been minimized.

Copy link
@jandudulski

jandudulski Feb 15, 2020

Contributor

I guess '>= 1.1.6', '< 2.0' would be more clear 😃

This comment has been minimized.

Copy link
@fidel

fidel Feb 17, 2020

Author Contributor

Such change, much controversion.

I went with that pattern since it's the recommended approach:

If you want to allow use of newer backwards-compatible versions but need a specific bug fix you can use a compound requirement:

# gemspec
spec.add_runtime_dependency 'library', '~> 2.2', '>= 2.2.1'

# bundler
gem 'library', '~> 2.2', '>= 2.2.1'

https://guides.rubygems.org/patterns/#pessimistic-version-constraint

end

0 comments on commit 088d015

Please sign in to comment.