Add support for AVR #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a bus-manager for sharing between tasks on AVR. Signed-off-by: Rahix <rahix@rahix.de>
dbrgn
reviewed
Oct 22, 2020
| } | ||
|
|
||
| // #[cfg(feature = "avr-device")] | ||
| // unsafe impl<T: Send> Send for AvrMutex<T> {} |
There was a problem hiding this comment.
I'm not qualified to review this PR, but there's some dead code here that could probably be removed (unless the AvrMutex is Send of course).
There was a problem hiding this comment.
Good question why I commented that out ... I would argure that it is Send as long as we're on an AVR device (which is single core). Interrupts are disabled while the mutex is held so no interrupt could preempt in the meantime and attempt to access the mutex concurrently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.