Skip to content

Commit

Permalink
Bump to rubocop 0.77.0
Browse files Browse the repository at this point in the history
Upgrade rubocop from version 0.75.1 to version 0.77.0. The biggest
breaking changes came from version 0.77.0 where many cops were re-named.
I started by trying to make sense of the issue linked to in the
CHANGELOG:

https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0770-2019-11-27
rubocop/rubocop#7077

But in the end I realized it was faster to just upgrade and let rubocop
cop warn me of any unknown cops that needed to be re-named in version
0.77.0. I kept running this command in my local `radius-spec` repo until
the errors stopped:

```
$ bin/rubocop --list --config .rubocop.yml
```
  • Loading branch information
jnebeker committed Aug 13, 2021
1 parent b574598 commit 2744c1f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions common_rubocop.yml
Expand Up @@ -56,7 +56,7 @@ Layout/AccessModifierIndentation:
# SupportedHashRocketStyles: key, separator, table
# SupportedColonStyles: key, separator, table
# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
Layout/AlignHash:
Layout/HashAlignment:
Enabled: true
EnforcedHashRocketStyle: key
EnforcedColonStyle: key
Expand All @@ -82,7 +82,7 @@ Layout/BlockAlignment:
#
# TODO: At some point this is split into both Layout/FirstArgumentIndentation
# and Layout/FirstParameterIndentation
Layout/IndentFirstArgument:
Layout/FirstArgumentIndentation:
Enabled: false

# This project only uses newer Ruby versions which all support the "squiggly"
Expand All @@ -91,7 +91,7 @@ Layout/IndentFirstArgument:
#
# Configuration parameters: EnforcedStyle.
# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
Layout/IndentHeredoc:
Layout/HeredocIndentation:
EnforcedStyle: squiggly

# We tend to indent multi-line operation statements. I think this is because it
Expand Down Expand Up @@ -248,14 +248,14 @@ Naming/FileName:
# `EOF` is a common terminal abbreviate indicating end-of-file. We allow this
# for those heredocs which represent "file" text.
#
# Configuration parameters: Blacklist.
# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
# Configuration parameters: ForbiddenDelimiters.
# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
Naming/HeredocDelimiterNaming:
Details: |
Use meaningful delimiter names to provide context to the text. The only
allowed `EO*` variant if `EOF` which has specific meaning for file content.
Blacklist:
ForbiddenDelimiters:
- !ruby/regexp '/(^|\s)(EO[A-EG-Z]{1}|END)(\s|$)/'

# It is generally a good idea to match the instance variable names with their
Expand Down
2 changes: 1 addition & 1 deletion radius-spec.gemspec
Expand Up @@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = ">= 2.5"

spec.add_runtime_dependency "rspec", "~> 3.7"
spec.add_runtime_dependency "rubocop", "~> 0.75.1"
spec.add_runtime_dependency "rubocop", "~> 0.77.0"
spec.add_runtime_dependency "rubocop-rails", "~> 2.5.2"

spec.add_development_dependency "bundler", ">= 2.2.10"
Expand Down

0 comments on commit 2744c1f

Please sign in to comment.