Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue281 slp creation #282

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Issue281 slp creation #282

merged 4 commits into from
Jul 13, 2020

Conversation

sebuer
Copy link
Collaborator

@sebuer sebuer commented Jul 10, 2020

Fix SLP creation using different step-sizes and add corresponding tests.

@sebuer sebuer requested a review from ss391347 July 10, 2020 10:39
@sebuer sebuer changed the title Issue281 slp creation WIP: Issue281 slp creation Jul 10, 2020
@sebuer
Copy link
Collaborator Author

sebuer commented Jul 10, 2020

There seems to be an issue with pytest fixture caching. As a workaround I renamed the fixture using the non default parameter. This seems to be related to pytest-dev/pytest#570
Since Python2.7 is EOL, pytest is stuck at 4.6.
Maybe this can be a reason to drop Python2 support.
https://docs.pytest.org/en/stable/py27-py34-deprecation.html

@sebuer sebuer changed the title WIP: Issue281 slp creation Issue281 slp creation Jul 10, 2020
@ss391347 ss391347 self-assigned this Jul 10, 2020
@ss391347
Copy link
Collaborator

@sebuer: Do your changes fix both issues, #280 and #281?

@sebuer
Copy link
Collaborator Author

sebuer commented Jul 10, 2020

No, #280 is not fixed by this PR.

@ss391347 ss391347 linked an issue Jul 10, 2020 that may be closed by this pull request
SLPs are only calculated on first Object creation #281
Closed
@ss391347 ss391347 merged commit 0bb5363 into development Jul 13, 2020
@ss391347 ss391347 deleted the issue281_slp_creation branch July 13, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ss391347 ss391347 Awaiting requested review from ss391347

Assignees

@ss391347 ss391347

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLPs are only calculated on first Object creation
2 participants
@sebuer @ss391347