Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Occasionnal Pipe Closures #41

Merged
merged 1 commit into from Jun 22, 2019
Merged

Fix Occasionnal Pipe Closures #41

merged 1 commit into from Jun 22, 2019

Conversation

bonedaddy
Copy link
Contributor

@bonedaddy bonedaddy commented Jun 22, 2019

Been doing some research into occasional errors the database package is getting involving "write: broken pipe" errors. Doing some research it appears that the max connection lifetime is the source:

go-sql-driver/mysql#446
go-sql-driver/mysql#934

This PR attempts to address the issue by setting the maximum connection lifetime to 60 minutes.

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #41 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage    67.9%   67.94%   +0.03%     
==========================================
  Files          14       14              
  Lines         885      886       +1     
==========================================
+ Hits          601      602       +1     
  Misses        197      197              
  Partials       87       87
Impacted Files Coverage Δ
database.go 86.66% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3973e...5a7ba27. Read the comment docs.

@bonedaddy bonedaddy merged commit 7ba523c into master Jun 22, 2019
@bonedaddy bonedaddy deleted the time branch June 22, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants