Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#95] Upgrade prometheus-operator monitoring to v0.55.1 #96

Merged
merged 1 commit into from
May 2, 2022

Conversation

brusdev
Copy link
Contributor

@brusdev brusdev commented Apr 5, 2022

No description provided.

@jeremyary
Copy link
Collaborator

hey @brusdev seems that vet's identified an issue around a missing dependency declaration or similar, could you PTAL? Thanks!!

@brusdev brusdev force-pushed the upgrade_monitoring_v0.55.1 branch from 408802b to 4d1a1e6 Compare April 6, 2022 08:21
@brusdev
Copy link
Contributor Author

brusdev commented Apr 6, 2022

@jeremyary this issue was fixed in go 1.17, see kubernetes-sigs/controller-tools#643
I have just pushed a commit to update the github workflow too

Copy link
Member

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase on our next branch and change the PR to that branch

@brusdev brusdev force-pushed the upgrade_monitoring_v0.55.1 branch from 4d1a1e6 to bfde175 Compare April 8, 2022 07:32
@brusdev brusdev changed the base branch from main to next April 8, 2022 07:33
@brusdev brusdev requested a review from tchughesiv April 8, 2022 07:33
@brusdev
Copy link
Contributor Author

brusdev commented Apr 22, 2022

@jeremyary @tchughesiv I rebased on next branch

Copy link
Member

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchughesiv tchughesiv merged commit feaf750 into RHsyseng:next May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants