Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve packaging #196

Merged
merged 7 commits into from Feb 17, 2022
Merged

Improve packaging #196

merged 7 commits into from Feb 17, 2022

Conversation

eggplants
Copy link
Contributor

I introduce useful packaging way to use setup.cfg, setup.py, and pyproject.toml.

It will be able to use both pip install . and pip install -e ., and also write almost configurations of tools in setup.cfg.

When you want to install dev dependencies, you can do it by running pip install .[dev].

@@ -21,7 +21,7 @@ Then you have to [create a release](https://github.com/blog/1547-release-your-so

And then upload the release to pypi:

python setup.py register sdist --formats=gztar,zip bdist_egg upload
python setup.py sdist && twine upload dist/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be uploading wheels also, but fine as is as it already improves on previous commands.

some packages have to be installed before. So please install the packages
listed in requirements.development.txt:
``pip install -r requirements.development.txt``
- ``test``: some unit and integrations tests. In order to run the tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly sure this is deprecated:

Maybe it is okay for now, but better to point people to tox if they want something easy to manage.

I'm somewhat okay with the change you made as is, because it makes it no worse, but this is something we have to fix sometime.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, I'm a bit on the fence on removing the requirements.txt files, but I can't really see a good case for keeping them. I'm open to hearing other opinions, worse case scenario we can add them back but I think it is best to not use requirements.txt to populate the dependencies so either way your change to setuptools keywords (now in setup.cfg) is for the better.

@eggplants
Copy link
Contributor Author

reverted deletion of requirements.txt.

@nicholascar nicholascar merged commit 38c939d into RDFLib:master Feb 17, 2022
@eggplants eggplants deleted the improve_packaging branch February 17, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants