Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused hikari config from application properties #829

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Remove unused hikari config from application properties #829

merged 1 commit into from
Jun 3, 2024

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented May 13, 2024

  • Getting an error: java.lang.IllegalStateException: The configuration of the pool is sealed once started. Use HikariConfigMXBean for runtime changes.
  • I think these were not used and tested for a while (in previous releases) and was used in the latest release (which resulted in the error), but if this is needed, we would need a custom implementation of the HikariConfig

yatharthranjan
yatharthranjan approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Bdegraaf1234
Bdegraaf1234 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I recall encountering this problem and not being able to fix it with just these changes, but I think that was in the backport branch (v0.8). Just something to keep an eye out for.

Merging

@Bdegraaf1234 Bdegraaf1234 merged commit 9245ecb into dev Jun 3, 2024
5 of 7 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the update-application-config branch June 3, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan approved these changes

@Bdegraaf1234 Bdegraaf1234 Bdegraaf1234 approved these changes

@nivemaham nivemaham Awaiting requested review from nivemaham nivemaham is a code owner

@peyman-mohtashami peyman-mohtashami Awaiting requested review from peyman-mohtashami peyman-mohtashami is a code owner

@pvannierop pvannierop Awaiting requested review from pvannierop pvannierop is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpgxvii @yatharthranjan @Bdegraaf1234