Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Script Errors from Northstar Callbacks Fatal #698

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EladNLG
Copy link
Member

@EladNLG EladNLG commented May 12, 2024

Read Title.

Why

Because:

  • Errors are incredibly confusing when non-fatal - there is no indicator that an error is happening
  • The error is unknown without a try/catch block
  • Errors cannot be tracked to a line, or file, and its location has to be figured out manually
  • They can throw a game into an unexpected state with no indicator, confusing both players AND developers

@Jan200101
Copy link
Member

here is the function definition for other reviewers:

SQRESULT sq_call(HSQUIRRELVM v, SQInteger params, SQBool retval, SQ-
Bool raiseerror);

code looks good, unsure if this will affect any existing mods (though if they are affected they already have an error so perhaps breaking already broken mods even more is best)

@Jan200101 Jan200101 added the needs testing Changes from the PR still need to be tested label May 12, 2024
@GeckoEidechse GeckoEidechse added the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants