Add CreateScriptInstance #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catornot
approved these changes
Apr 25, 2024
|
Ok, genuinely, how can this be even tested? |
Usually the approach is to have a small PoC script mod that highlights the change. I don't understand enough atm to tell you whether that would make sense in this case ^^" |
Unfortunately, no known part of the codebase (outside of #691) uses pushobject/createscriptinstance. My guess is that #691 will test this by proxy? |
|
I did test the server offsets in a plugin :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function that converts entities to SQObjects to the SquirrelManagers.