Compiler Warnings #645
Draft
Compiler Warnings #645
+220
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
merge conflicts
github-actions
bot
removed
the
merge conflicts
github-actions
bot
added
the
merge conflicts
github-actions
bot
added
merge conflicts
Jan200101
reviewed
Mar 13, 2024
| PRIVATE -Wall | ||
| -Wextra | ||
| -Wpedantic | ||
| -Werror |
There was a problem hiding this comment.
Please do not make warnings fatal by default.
what is and isn't a warning can change a lot between compiler versions causing phantom errors that only appear in the CI but not locally or the other way around.
There was a problem hiding this comment.
honestly i dont think this PR is ever gonna get merged, since it should really get split up into a bunch more PRs, so I think that it's ok to have fatal warnings on this branch specifically, so that it sort of "proves" that i didnt miss any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this build will absolutely fail all the time because warnings are fatal :)
but yeah