Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust for restructured verified-mods.json #642

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Jan 19, 2024

Updates the launcher code to deal with adjusted verified mods JSON structure defined in

Testing:

To test, run Northstar with:

.\NorthstarLauncher.exe -customverifiedurl=https://raw.githubusercontent.com/R2Northstar/VerifiedMods/f48c43b980490fd80761d967866e16cfd0c793ab/verified-mods.json

and join any server with a MAD mod.

@GeckoEidechse
Copy link
Member Author

Doesn't build rn cause I'm having a skill issue and don't know how to just get the member of the thunderstore key and then iterate over its members as before.

@GeckoEidechse GeckoEidechse force-pushed the feat/update-for-new-verified-json branch from 124ebee to 54532ae Compare January 19, 2024 22:42
@GeckoEidechse GeckoEidechse marked this pull request as ready for review January 24, 2024 01:23
@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 24, 2024
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@GeckoEidechse GeckoEidechse removed the needs code review Changes from PR still need to be reviewed in code label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants