Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice for run_northstar.txt #639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jan200101
Copy link
Member

related to #508
followed up by #512

run_northstar.txt is a relic of times gone by and is no longer needed.

@GeckoEidechse GeckoEidechse changed the title add deprecation notice for run_northstar.txt Add deprecation notice for run_northstar.txt Jan 14, 2024
@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 14, 2024
@itscynxx
Copy link
Contributor

itscynxx commented Jan 17, 2024

Actually found a bug after posting my comment, my bad

The error pops up twice

Apart from the entire twice thing, the code looks like it's good, the error is clear, and gives a proper solution
image

@Jan200101
Copy link
Member Author

When does it occur twice?
when launching with just -northstar or via NorthstarLauncher?

@itscynxx
Copy link
Contributor

When does it occur twice?
when launching with just -northstar or via NorthstarLauncher?

launching Titanfall 2 via Steam using -windowed -noborder, with run_northstar.txt in the Titanfall2 directory with a 1 inside it, on windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants