Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify entrypoints (Launcher, wsock32 proxy) #585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unify entrypoints (Launcher, wsock32 proxy) #585

wants to merge 1 commit into from
+143 −266

Conversation

Jan200101
Copy link
Member

@Jan200101 Jan200101 commented Oct 25, 2023 •
edited

Merges the wsock and launcher directories together.

Full changes:

  • separated code that was common to loader.cpp
  • fail conditions were moved into relevant functions
  • put common code into a NorthstarLoader library to be reused

@Jan200101 Jan200101 changed the title Pr/unify loader Unify entrypoints (Launcher, wsock32 proxy) Nov 18, 2023
@Jan200101
Copy link
Member Author

rebased, fixed some things up, tested it myself (though I want someone else to test it too)

@Jan200101 Jan200101 marked this pull request as ready for review November 18, 2023 22:08
@Jan200101 Jan200101 added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 18, 2023
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
@Jan200101
Copy link
Member Author

remade from scratch
split things up into fewer segments so its easier to digest

@GeckoEidechse GeckoEidechse removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 8, 2024
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0358 p0358 p0358 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
merge conflicts Blocked by merge conflicts, waiting on the author to resolve needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jan200101 @p0358 @GeckoEidechse