-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vite-plugin): set assets path in build to /assets #5745
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4975944
to
b1fc117
Compare
Deploying qwik-docs with Cloudflare Pages
|
oh I actually need this change haha |
@PatrickJS you can configure this for yourself, it just changes the default |
yeah I see that now 😂 I'll update on my end. plus I also want to keep the names for the assets the same for SEO. It's good to fix this as the default |
@wmertens I want to move all assets to another folder. so dist/client and dist/assets and dist/server the idea is that I may want to handle assets differently or uploaded somewhere else. I can configure dist/client and dist/server |
b1fc117
to
9ec0384
Compare
for SEO reasons you want to keep the name of the file so I changed it to this for my app assetFileNames: 'assets/[hash]/[name][extname]' it also helps to see which fonts are loading in |
for images we want to keep the image name for seo so |
how about |
@wmertens yup that works |
I updated the pr |
for v1 can we do |
Right now, if
rollupOptions.output.assetFilenames
is not defined, assets will be output asbuild/q-[hash].ext
.This PR changes that default setting to
assets/[hash].[ext]
.The reasoning is that for post-processing like
$localize
that copies the build files into/build/[locale]/
, it makes no sense to have to copy.css
files and others, especially since all css files will be automatically added to the head and so you'll get a per-language copy of the css file.This is a slightly breaking change, in case some custom scripting is expecting all files to live under
/build
. (Seems unlikely though)