chore: Remove undici, set minimum node version to 18.17 #5702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Google API Key | 1d9fa88 | packages/docs/scripts/showcase.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
wmertens
force-pushed
the
remove-undici
branch
from
186d466
to
eee9199
Compare
wmertens
force-pushed
the
remove-undici
branch
from
eee9199
to
ca09a42
Compare
wmertens
force-pushed
the
remove-undici
branch
from
ca09a42
to
1681c2b
Compare
* feat(v2): q:container in CSR mode * feat(v2): add slots to new created component * after merge changes * cleanup * fix build * cleanup
* test(v2): add failing QwikDev#1945 test * fix 1945 test * fix build
- disallow source imports from e2e - narrow jsx-runtime exports and remove importing from src - move testing infra to @builder.io/qwik/testing
fix(v2): respect no-serialize
* fix(v2): lexial scope e2e test fixes * fixup! fix(v2): lexial scope e2e test fixes --------- Co-authored-by: Miško Hevery <misko@hevery.com>
fix(v2): correct tag nesting
fix(v2): dont crash on rendering MDX
* fix(optimizer): correctly emit fixed children The only time when we don't know what the children are statically is when they're overridden by spread props. * chore: pnpm api.update
The node engines "^18.17.0 || ^20.3.0 || >=21.0.0" are taken from the `sharp` dependency, which probably has good reason for them. All of these include global fetch, so undici is not needed. Bun and deno also include fetch.
|
can we change the min version to node 20? 😁 20 is a lot faster |
|
is this PR still valid or is it abandoned ? |
If I am not mistaken they are waiting for version 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sharprequires "^18.17.0 || ^20.3.0 || >=21.0.0", and that's the cause of installation issues.Furthermore, global fetch is in node since v18, so we don't need undici any more.
Bun and Deno also include fetch.