docs: added package manager tabs #5649

the-r3aper7 · 2023-12-29T17:56:05Z

Overview

What is it?

Feature / enhancement
Bug
Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

1. One use case
1. Another use case

Checklist:

My code follows the developer guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
Added new tests to cover the fix / functionality

netlify · 2023-12-29T17:56:07Z

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`c1c9343`

the-r3aper7 · 2023-12-29T17:59:12Z

should i add @qwik-ui/headless to vite optimization dependencies. @gioboa

gioboa · 2023-12-29T18:54:22Z

No, the latest @qwik-ui/headless solves the big bundle size issue.

the-r3aper7 · 2023-12-29T18:56:59Z

some CI tests failed how can i make it right?

gioboa · 2023-12-29T19:10:15Z

packages/docs/src/components/package-manager-tabs/index.tsx

+  return null;
+};
+
+const setCookie = (name: string, value: string, options: CookieOptions = {}) => {


Can you read cookie inside routeLoader$ pls?

--

We already have a setCookie method here packages/docs/src/routes/(shop)/utils.ts.
Can you create a common method to manage both cases pls?

i will make those changes by tomorrow.

Still relevant.

gioboa · 2023-12-29T19:22:31Z

I pushed a small change. Thanks for your commitment @the-r3aper7

the-r3aper7 · 2023-12-29T19:23:22Z

I pushed a small change. Thanks for your commitment @the-r3aper7

thank you, i like that icon change.

the-r3aper7 · 2024-01-02T08:49:48Z

@gioboa i have make changes regarding to get the cookie but i am not able to think of getting setCookie correct as we need to pass Cookie object to setCookie and should i change the setCookie function in shop/utils WDYT?

the-r3aper7 · 2024-01-09T16:36:06Z

@gioboa i have tried basic document.cookie in setCookie it does not work with the shop as it is not able to set cartId in cookies. can you give some ideas?

wmertens · 2024-01-17T14:27:05Z

@the-r3aper7 So you're having trouble with the setCookie function? Can you explain more, and rebase?

the-r3aper7 · 2024-01-17T17:36:15Z

@the-r3aper7 So you're having trouble with the setCookie function? Can you explain more, and rebase?

yeah i was not able to set the Cookie using setCookie as it requires Cookie object which is can be obtained from RequestEventLoader and i am able to process that on client and i am currently using document.cookie to set cookie.

after that i tried to change the setCookie with document.cookie which was not successful 😞

wmertens · 2024-01-17T17:40:50Z

I'm confused about your setCookie function that takes 3 arguments, the third called options, but you're passing a string

the-r3aper7 · 2024-01-17T17:45:48Z

I'm confused about your setCookie function that takes 3 arguments, the third called options, but you're passing a string

i am directly adding cookie to the browser. am i misinterpreting something?

wmertens

I don't see you reading the package manager cookie to set the context for SSR of the package manager?

wmertens · 2024-01-30T14:13:06Z

packages/docs/src/components/package-manager-tabs/NpmIcon.tsx

+        id="image0_13_2"
+        width="630"
+        height="630"
+        xlink:href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAnYAAAJ2CAYAAADSVM/5AAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAA2HSURBVHhe7dm/ilRXAMDhc1eDnUiw8F+ZxtLe2lew8T1k0VJZ8hqCL7HPsLB1CNiIGJSAgo1GZ3InDiGSNFnc2evP74PLnjnbXM5czvkxdzoaYz0AAPjm7W3/AgDwjRN2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AICI6WiM9Xa8LHtzc66XeWsAwHdsmsZYrbYflmW5YbdZNGEHACzNghvFq1gAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIqajMdbb8bJM03xny7y1OqsO8G2YT0rOwoIbRdjxhQu3bo1Ld+6Mac+PuQBLtl6txpvDw/H++Hg7w84IuxMQdju3We0r9++P648ffw476w+wTPMZuQm7Fw8ejN9+/tkvd7sm7E5A2O3cZrWv7u+P648ejeEXO4Bl24Tdw4fj5cGBsNu1BTeK0xsAIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHT0Rjr7XhZpmm+s2XeWtVmta/u74/rjx7Nya/56Vh//Dg+vH49xqdP2xlOxbxnT/Pe/cOVK2M6f347yalZrcaLhw/Hy4ODMZ+Y7NKCG0XY8TdhR9WH58/Hr/fujT9evfq8t/D1zcs6zeF8/uq18dPTp+PCtWvbf3BqhN3ZEXYnIOx2TthR9f7Zs/HL7dvjw8uXDsBTtNlDzt+8OW4eHo4LN258nuT0CLuzs+BGcXoD3w2H3+myvnD2hB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIO76wXq3Ger2eB/M1j12ub/7668Gen2d2Z71d9//6Plxf55qf6c1evdmz4Z+mo/nx2I6XZZpsxmfgwq1b49KdO2Pa0/x0fHr7dvz+5MlYvXu3neG0nLt8efx49+44d/HidobTsom6N4eH4/3x8XaGnVlwowg7/sWqUzTvKOyIPWR3PNdnRNidgLADAJZowY3ifRsAQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEdPRGOvteFn25uZcL/PWAIDv2DSNsVptPyzLcsMOAID/xatYAIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMAiBB2AAARwg4AIELYAQBECDsAgAhhBwAQIewAACKEHQBAhLADAIgQdgAAEcIOACBC2AEARAg7AIAIYQcAECHsAAAihB0AQISwAwCIEHYAABHCDgAgQtgBAEQIOwCACGEHABAh7AAAIoQdAECEsAMASBjjT53R4qbnekMRAAAAAElFTkSuQmCC"


I'm sure there are NPM logos in SVG without embedded PNGs, no?

wmertens · 2024-03-04T10:03:42Z

packages/docs/src/components/package-manager-tabs/index.tsx

+  return null;
+};
+
+const setCookie = (name: string, value: string, options: CookieOptions = {}) => {


Still relevant.

docs: added package manager tabs

1de10e2

the-r3aper7 mentioned this pull request Dec 29, 2023

docs: added Package manager tabs #5174

Closed

7 tasks

lock file 🔑

1cb3a5f

gioboa reviewed Dec 29, 2023

View reviewed changes

chore: small icon change

d6b36b7

chore: add missing import

215eb2b

gioboa mentioned this pull request Dec 30, 2023

[🐞] error during build: RollupError: Duplicate export 's_DyVc0YBIqQU' #4768

Open

to loaders

c1c9343

wmertens reviewed Mar 4, 2024

View reviewed changes

the-r3aper7 mentioned this pull request Mar 15, 2024

[RFC]: build a developer dashboard for tracking repository build status stdlib-js/google-summer-of-code#39

Closed

5 tasks

PatrickJS marked this pull request as draft May 6, 2024 05:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: added package manager tabs #5649

docs: added package manager tabs #5649

the-r3aper7 commented Dec 29, 2023

netlify bot commented Dec 29, 2023 •

edited

the-r3aper7 commented Dec 29, 2023

gioboa commented Dec 29, 2023

the-r3aper7 commented Dec 29, 2023

gioboa Dec 29, 2023 •

edited

the-r3aper7 Dec 29, 2023

wmertens Mar 4, 2024

gioboa commented Dec 29, 2023

the-r3aper7 commented Dec 29, 2023 •

edited

the-r3aper7 commented Jan 2, 2024 •

edited

the-r3aper7 commented Jan 9, 2024 •

edited

wmertens commented Jan 17, 2024

the-r3aper7 commented Jan 17, 2024

wmertens commented Jan 17, 2024

the-r3aper7 commented Jan 17, 2024

wmertens left a comment

wmertens Jan 30, 2024

wmertens Mar 4, 2024

docs: added package manager tabs #5649

Are you sure you want to change the base?

docs: added package manager tabs #5649

Conversation

the-r3aper7 commented Dec 29, 2023

Overview

What is it?

Description

Use cases and why

Checklist:

netlify bot commented Dec 29, 2023 • edited

👷 Deploy request for qwik-insights pending review.

the-r3aper7 commented Dec 29, 2023

gioboa commented Dec 29, 2023

the-r3aper7 commented Dec 29, 2023

gioboa Dec 29, 2023 • edited

Choose a reason for hiding this comment

the-r3aper7 Dec 29, 2023

Choose a reason for hiding this comment

wmertens Mar 4, 2024

Choose a reason for hiding this comment

gioboa commented Dec 29, 2023

the-r3aper7 commented Dec 29, 2023 • edited

the-r3aper7 commented Jan 2, 2024 • edited

the-r3aper7 commented Jan 9, 2024 • edited

wmertens commented Jan 17, 2024

the-r3aper7 commented Jan 17, 2024

wmertens commented Jan 17, 2024

the-r3aper7 commented Jan 17, 2024

wmertens left a comment

Choose a reason for hiding this comment

wmertens Jan 30, 2024

Choose a reason for hiding this comment

wmertens Mar 4, 2024

Choose a reason for hiding this comment

netlify bot commented Dec 29, 2023 •

edited

gioboa Dec 29, 2023 •

edited

the-r3aper7 commented Dec 29, 2023 •

edited

the-r3aper7 commented Jan 2, 2024 •

edited

the-r3aper7 commented Jan 9, 2024 •

edited