feat(eslint): rule for sync$() #5638
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
wmertens
reviewed
Mar 4, 2024
| ]); | ||
|
|
||
| return context.getScope().through.some(scopeVar => | ||
| scopeVar.identifier.name === variable && browserAPIs.has(variable) |
There was a problem hiding this comment.
Won't this run into trouble when you do { const document = "foo"; sync$(() => document)}?
Since all these are global and globals aren added to the scope array (see the bundles here), would it instead be possible to just check if it's using only globals?
You could even check if they're browser globals but since it would crash immediately for undefined globals I think that's not necessary.
|
Hi @Lemon2311 are you still working on this or is it abandoned? |
|
Hello @gioboa, I haven`t looked into this more since this draft. I saw u assigned @ahmaddonishyar to the issue so I suppose not for now, if he doesn`t fix it I can give it another go then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gioboa send me as an example merge #5455, but since then @mhevery in #5572 refactored the code as all the ruleTesters were just placed inside qwik.unit.ts. I made this changes, implemented the noSyncClosure rule, but I can`t seem to find where he moved the ruleTester implemetations so that I can include my test for the noSyncClosure rule.