-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vercel serverless #4736
feat: vercel serverless #4736
Conversation
Co-Authored-By: Shyam Seshadri <97863898+shyam-builder@users.noreply.github.com> Co-Authored-By: Akshat Garg <60404253+akshatgarg12@users.noreply.github.com>
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for qwik-insights canceled.
|
Deploying with Cloudflare Pages
|
anything missing @adamdbradley ? 🚀 |
You rock @adamdbradley 🙌 |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
7973510 | Generic High Entropy Secret | 21514fe | packages/docs/src/routes/demo/cookbook/mediaController/index.tsx | View secret |
7964571 | Generic High Entropy Secret | 21514fe | packages/docs/src/routes/demo/cookbook/mediaController/index.tsx | View secret |
2259981 | Generic High Entropy Secret | 21514fe | packages/docs/src/routes/demo/cookbook/mediaController/index.tsx | View secret |
2259981 | Generic High Entropy Secret | 21514fe | packages/docs/src/routes/demo/cookbook/mediaController/index.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@adamdbradley is busy with another project. Can we just test and land this? Happy to help with it. |
Happy to help as well! I think it's an important feature as qwik developers who use auth.js and don't have a database deployed to the edge (which is usually the case for starters) will experience extra latency. @mhevery is there anything blocking? |
Last I checked with @adamdbradley this was not finished/tested. Hence draft. It would require someone to get the last mile. Mainly do the testing/docs to make sure all is working. |
I'm going to work with someone to redo this PR and update it |
we're redoing this here #6355 |
No description provided.