Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vercel serverless #4736

Closed
wants to merge 11 commits into from
Closed

feat: vercel serverless #4736

wants to merge 11 commits into from

Conversation

adamdbradley
Copy link
Contributor

No description provided.

adamdbradley and others added 4 commits July 4, 2023 07:47
Co-Authored-By: Shyam Seshadri <97863898+shyam-builder@users.noreply.github.com>
Co-Authored-By: Akshat Garg <60404253+akshatgarg12@users.noreply.github.com>
@stackblitz
Copy link

stackblitz bot commented Jul 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for qwik-insights canceled.

Name Link
🔨 Latest commit 471784c
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/64f75eeff6f7b70008d9eb53

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 471784c
Status: ✅  Deploy successful!
Preview URL: https://d9451b2e.qwik-docs.pages.dev
Branch Preview URL: https://vercelserverless.qwik-docs.pages.dev

View logs

@zanettin
Copy link
Collaborator

anything missing @adamdbradley ? 🚀

@mrhoodz
Copy link
Contributor

mrhoodz commented Aug 11, 2023

You rock @adamdbradley 🙌

@zanettin zanettin added the WAITING FOR: team Waiting for one of the core team members to review and reply label Aug 22, 2023
@gitguardian
Copy link

gitguardian bot commented Sep 1, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7973510 Generic High Entropy Secret 21514fe packages/docs/src/routes/demo/cookbook/mediaController/index.tsx View secret
7964571 Generic High Entropy Secret 21514fe packages/docs/src/routes/demo/cookbook/mediaController/index.tsx View secret
2259981 Generic High Entropy Secret 21514fe packages/docs/src/routes/demo/cookbook/mediaController/index.tsx View secret
2259981 Generic High Entropy Secret 21514fe packages/docs/src/routes/demo/cookbook/mediaController/index.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@zanettin zanettin added the STATUS-2: PR waiting for review This PR is waiting for review and approval before merge label Sep 1, 2023
@mhevery
Copy link
Contributor

mhevery commented Sep 5, 2023

@adamdbradley is busy with another project. Can we just test and land this? Happy to help with it.

@mhevery mhevery marked this pull request as draft September 6, 2023 20:53
@maiieul
Copy link
Collaborator

maiieul commented Sep 28, 2023

Happy to help as well!

I think it's an important feature as qwik developers who use auth.js and don't have a database deployed to the edge (which is usually the case for starters) will experience extra latency.

@mhevery is there anything blocking?

@mhevery
Copy link
Contributor

mhevery commented Oct 4, 2023

Last I checked with @adamdbradley this was not finished/tested. Hence draft. It would require someone to get the last mile. Mainly do the testing/docs to make sure all is working.

@wmertens wmertens added TYPE: enhancement New feature or request COMP: qwik-city COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it and removed WAITING FOR: team Waiting for one of the core team members to review and reply labels Mar 4, 2024
@PatrickJS
Copy link
Member

I'm going to work with someone to redo this PR and update it

@PatrickJS PatrickJS self-assigned this May 1, 2024
@PatrickJS
Copy link
Member

we're redoing this here #6355

@PatrickJS PatrickJS closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it COMP: qwik-city COMP: starters STATUS-2: PR waiting for review This PR is waiting for review and approval before merge TYPE: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants