build: make root.tsx optional #3527
Draft
+50
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Deploying with
|
| Latest commit: |
678d503
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b4342f56.qwik-docs.pages.dev |
| Branch Preview URL: | https://pr-root-tsx.qwik-docs.pages.dev |
|
@shairez can you better explain the motivation? |
|
Yes, it's something me and @manucorporat figured out when trying to build the cypress plugin. I ran into some limitations when trying to fix this, but I need to complete this work when I'll have time |
wmertens
reviewed
Nov 26, 2023
|
|
||
| return fs.existsSync(path); | ||
| } | ||
| return false; |
There was a problem hiding this comment.
maybe better to assume they exist, so that it's like previous behavior?
|
oh I actually ran into this when I was working on Qwik Start. It should be optional |
|
can we redo this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Make build
root.tsxfor client mode building to make it easier for testing tools to run Qwik libraries.