New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update black #206
update black #206
Conversation
Pipfile.lock
Outdated
"black": { | ||
"hashes": [ | ||
"sha256:1c02557aa099101b9d21496f8a914e9ed2222ef70336404eeeac8edba836fbea" | ||
], | ||
"index": "pypi", | ||
"version": "==20.8b1" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused about why "black" and its dependencies are added here, whereas they are already defined as dev packages. These new definitions are also removed from Pipfile.lock after running pipenv lock
, so I don't think they are supposed to be committed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have done something wrong indeed!
I often feel like an old lady when working with pipenv
, this must be some kind of curse because it is not a very complicated tool :'D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed, I just ran a pipenv install --dev --selective-upgrade "black==20.8b1"
from master.
I think that I initially forgot the --dev
yesterday, then I somehow failed or forgot to revert the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaaand also required a pipenv lock --keep-outdated
which added this hash: https://github.com/Qwant/idunn/pull/206/files#diff-a86c67a0a29ed0e95909b9b7c420140f302d17399ee6dcce4e1a51a14d27fd51R499.
9747448
to
1504697
Compare
1504697
to
80d5d02
Compare
Update black to latest version.
Most impactful changes appear to be: