Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update black #206

Merged
merged 1 commit into from Feb 26, 2021
Merged

update black #206

merged 1 commit into from Feb 26, 2021

Conversation

remi-dupre
Copy link
Contributor

@remi-dupre remi-dupre commented Feb 25, 2021

Update black to latest version.

Most impactful changes appear to be:

  • a bit of normalization in the docstrings
  • trailing commas enforce to split into one line per item (apparently this is called magic trailing)

Pipfile.lock Outdated
Comment on lines 34 to 40
"black": {
"hashes": [
"sha256:1c02557aa099101b9d21496f8a914e9ed2222ef70336404eeeac8edba836fbea"
],
"index": "pypi",
"version": "==20.8b1"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused about why "black" and its dependencies are added here, whereas they are already defined as dev packages. These new definitions are also removed from Pipfile.lock after running pipenv lock, so I don't think they are supposed to be committed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have done something wrong indeed!

I often feel like an old lady when working with pipenv, this must be some kind of curse because it is not a very complicated tool :'D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed, I just ran a pipenv install --dev --selective-upgrade "black==20.8b1" from master.

I think that I initially forgot the --dev yesterday, then I somehow failed or forgot to revert the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remi-dupre remi-dupre merged commit 9a5b2f4 into master Feb 26, 2021
@remi-dupre remi-dupre deleted the black-update branch February 26, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants