Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple config guide #2

Merged
merged 6 commits into from Sep 23, 2021
Merged

Adding simple config guide #2

merged 6 commits into from Sep 23, 2021

Conversation

samolego
Copy link
Contributor

I've added a guide to creating simple configs using gson. I plan to extend it further as well

What do you think about it?

@Patbox
Copy link

Patbox commented Sep 22, 2021

Looks good to me

@samolego
Copy link
Contributor Author

Sorry for last two small commits, it seems that my checks weren't good 😄 ...

@Southpaw1496
Copy link

I wouldn't worry, they'll probably be squashed in the end.

Copy link
Member

@Tom-The-Geek Tom-The-Geek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍

docs/config/gson_config.md Outdated Show resolved Hide resolved
docs/config/gson_config.md Show resolved Hide resolved
docs/config/gson_config.md Outdated Show resolved Hide resolved
@Genau6502 Genau6502 marked this pull request as ready for review September 23, 2021 06:58
docs/config/gson_config.md Outdated Show resolved Hide resolved
Co-authored-by: Tom_The_Geek <23531706+Tom-The-Geek@users.noreply.github.com>
@Genau6502 Genau6502 merged commit 97d7c0f into QuiltServerTools:master Sep 23, 2021
@samolego samolego deleted the feature/config branch September 23, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants