Update pre-commit hook versions #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
requested review from
ElizabethSantorellaQC,
MarcAntoineSchmidtQC and
tbenthompson
as code owners
| @@ -98,7 +98,8 @@ def _to_standardized_mat(mat): | |||
|
|
|||
| times = pd.DataFrame( | |||
| index=pd.MultiIndex.from_product( | |||
| [ops_to_run, matrices.keys()], names=["operation", "storage"], | |||
| [ops_to_run, matrices.keys()], | |||
There was a problem hiding this comment.
Huh... did this happen because the most recent black version re-implemented support for "magic trailing commas" as an indicator that the arguments should each be on different lines?
- Magic trailing comma: Finish "magic trailing comma" handling psf/black#1288
- black changelog: https://github.com/psf/black/blob/master/CHANGES.md
I don't think we meant to have those trailing commas there in the first place -- I would prefer no trailing comma and arguments on one line -- but this is totally fine too. I'm happy to defer such responsibilities to the wisdom of black :)
tbenthompson
pushed a commit
that referenced
this pull request
Oct 8, 2021
Update pre-commit hook versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Added aCHANGELOG.rstentry